notashes commented on PR #20168:
URL: https://github.com/apache/datafusion/pull/20168#issuecomment-3855335510
hey @adriangb, the benchmarks to test changes already exist in `main`. It
was merged with the PR #19373
The benchmark (`with_hashes`) already measure two key scenarios:
- single vs multiple columns (for rehash/combine logic)
- with nulls vs without nulls (in keys)
here are some numbers:
```
roup main
optimized
----- ----
---------
dictionary_utf8_int32: multiple, no nulls 2.73 31.1±0.46µs
? ?/sec 1.00 11.4±0.83µs ? ?/sec
dictionary_utf8_int32: multiple, nulls 1.92 39.4±0.61µs
? ?/sec 1.00 20.5±0.56µs ? ?/sec
dictionary_utf8_int32: single, no nulls 2.48 10.5±0.19µs
? ?/sec 1.00 4.2±0.57µs ? ?/sec
dictionary_utf8_int32: single, nulls 1.74 12.1±0.18µs
? ?/sec 1.00 7.0±0.31µs ? ?/sec
```
But perhaps we could also add benchmark tests for nulls in values (just for
sanity check)? let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
