gabotechs commented on code in PR #20175:
URL: https://github.com/apache/datafusion/pull/20175#discussion_r2772624975
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -609,6 +609,24 @@ impl HashJoinExec {
Arc::new(DynamicFilterPhysicalExpr::new(right_keys, lit(true)))
}
+ fn allow_join_dynamic_filter_pushdown(&self, config: &ConfigOptions) ->
bool {
+ if !config.optimizer.enable_join_dynamic_filter_pushdown {
+ return false;
+ }
+
+ // `preserve_file_partitions` can report Hash partitioning for
Hive-style
+ // file groups, but those partitions are not actually hash-distributed.
+ // Partitioned dynamic filters rely on hash routing, so disable them in
+ // this mode to avoid incorrect results.
+ if config.optimizer.preserve_file_partitions > 0
+ && self.mode == PartitionMode::Partitioned
+ {
Review Comment:
I imagine we'd want this at some point. Is there any issue we can link here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
