zhuqi-lucas commented on code in PR #19924:
URL: https://github.com/apache/datafusion/pull/19924#discussion_r2785438462
##########
datafusion/core/src/datasource/file_format/json.rs:
##########
@@ -46,12 +46,54 @@ mod tests {
use datafusion_common::internal_err;
use datafusion_common::stats::Precision;
+ use crate::execution::options::JsonReadOptions;
use datafusion_common::Result;
+ use datafusion_datasource::file_compression_type::FileCompressionType;
use futures::StreamExt;
use insta::assert_snapshot;
use object_store::local::LocalFileSystem;
use regex::Regex;
use rstest::rstest;
+ // ==================== Test Helpers ====================
+
+ /// Create a temporary JSON file and return (TempDir, path)
+ fn create_temp_json(content: &str) -> (tempfile::TempDir, String) {
+ let tmp_dir = tempfile::TempDir::new().unwrap();
+ let path = format!("{}/test.json", tmp_dir.path().to_string_lossy());
Review Comment:
Addressed in latest commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
