neilconway opened a new pull request, #20317: URL: https://github.com/apache/datafusion/pull/20317
## Which issue does this PR close? - Closes #20316. ## Rationale for this change Faster is better. ## What changes are included in this PR? This commit implements three optimizations: * In `StringViewArrayBuilder`, we recreated `block` after every call to `append_offset`. It is cheaper to instead clear and re-use `block`. * In `StringViewArrayBuilder::write()`, we re-validated that a string array consists of valid UTF8 characters. This was unnecessary work and can be skipped. * In the concat() UDF implementation, we miscalculated the initial size of the StringViewArrayBuilder buffer. This didn't lead to incorrect behavior but it resulted in unnecessarily needing to reallocate the buffer. ## Are these changes tested? Yes; no additional test cases warranted. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
