andygrove opened a new issue, #3499:
URL: https://github.com/apache/datafusion-comet/issues/3499

   ## Summary
   
   The Miri CI workflow is failing on all branches since `nightly-2026-02-12` 
with:
   
   ```
   error: failed to run custom build command for `quote v1.0.44`
   
   Caused by:
     process didn't exit successfully: `.../cargo-miri runner 
.../build-script-build` (exit status: 1)
     --- stderr
     fatal error: file ".../build-script-build" contains outdated or invalid 
JSON; try `cargo clean`
   ```
   
   ## Root Cause
   
   This is a confirmed upstream regression in cargo, **not** an issue with our 
code.
   
   - **Cause**: 
[rust-lang/cargo#16599](https://github.com/rust-lang/cargo/pull/16599) ("Add 
`host.runner` for wrapping host build target executions") was included in the 
cargo submodule update 
[rust-lang/rust#152240](https://github.com/rust-lang/rust/pull/152240) that 
shipped with `nightly-2026-02-12`. It accidentally applies `host.runner` to 
build script executions even when `host-config` is not enabled, causing 
`cargo-miri` to misinterpret build script binaries as JSON metadata.
   - **Upstream tracking**: 
[rust-lang/miri#4855](https://github.com/rust-lang/miri/issues/4855) (filed by 
dtolnay)
   - **Fix**: 
[rust-lang/cargo#16631](https://github.com/rust-lang/cargo/pull/16631) is 
already merged in cargo. It will ship once the cargo submodule is updated in 
rust-lang/rust and a new nightly is published.
   
   ## Evidence
   
   | Run | Nightly | Result |
   |-----|---------|--------|
   | 
[21918971946](https://github.com/apache/datafusion-comet/actions/runs/21918971946)
 | `nightly-2026-02-11` (9e79395f9) | Passed build |
   | 
[21929153302](https://github.com/apache/datafusion-comet/actions/runs/21929153302)
 | `nightly-2026-02-12` (7057231bd) | Failed with JSON error |
   | 
[21928770209](https://github.com/apache/datafusion-comet/actions/runs/21928770209)
 | `nightly-2026-02-12` (7057231bd) | Failed with JSON error |
   
   ## Proposed Fix
   
   Pin the nightly version in `.github/workflows/miri.yml` to 
`nightly-2026-02-11` until the upstream fix ships in a new nightly:
   
   ```diff
          - name: Install Miri
            run: |
   -          rustup toolchain install nightly --component miri
   -          rustup override set nightly
   +          rustup toolchain install nightly-2026-02-11 --component miri
   +          rustup override set nightly-2026-02-11
              cargo miri setup
   ```
   
   Once a fixed nightly is available, we should unpin back to `nightly`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to