mbutrovich commented on PR #3455: URL: https://github.com/apache/datafusion-comet/pull/3455#issuecomment-3891864526
> > Are there any configs that we can think of that would absolutely break Comet correctness? Either adding to a disallow list to filter out, or warn users about? > > Good point. We could put this functionality behind a new config flag with appropriate documentation. Something like `spark.comet.exec.respectDataFusionConfigs` defaulting to `false`? At a minimum I think that's a good start. It's a huge config state space, so I think guarding it behind another config that says something to the effect of "DataFusion configs are exposed for development purposes and possible workload-specific optimizations. Changing DataFusion configs could affect Comet correctness." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
