alamb commented on code in PR #20340:
URL: https://github.com/apache/datafusion/pull/20340#discussion_r2805410887
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -839,9 +839,35 @@ impl HashJoinExec {
can_project(&self.schema(), projection.as_deref())?;
let projection =
combine_projections(projection.as_ref(),
self.projection.as_ref())?;
- HashJoinExecBuilder::from(self)
- .with_projection_ref(projection)
- .build()
+
+ let cache = HashJoinExec::compute_properties(
Review Comment:
the point here is to be explcity (and more verbose) rather than resetting
the state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
