alamb commented on code in PR #19792:
URL: https://github.com/apache/datafusion/pull/19792#discussion_r2805432976
##########
datafusion/core/benches/reset_plan_states.rs:
##########
@@ -166,6 +166,8 @@ fn run_reset_states(b: &mut criterion::Bencher, plan:
&Arc<dyn ExecutionPlan>) {
/// making an independent instance of the execution plan to re-execute it,
avoiding
/// re-planning stage.
fn bench_reset_plan_states(c: &mut Criterion) {
+ env_logger::init();
Review Comment:
I wonder if this is an intended change
##########
datafusion/ffi/src/execution_plan.rs:
##########
@@ -192,7 +192,7 @@ impl Drop for FFI_ExecutionPlan {
pub struct ForeignExecutionPlan {
name: String,
plan: FFI_ExecutionPlan,
- properties: PlanProperties,
+ properties: Arc<PlanProperties>,
Review Comment:
I agree with your analysis -- since the actual `extern "C"` signature hasn't
change, this change should be backwards compatibile.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
