alamb opened a new pull request, #20346:
URL: https://github.com/apache/datafusion/pull/20346

   ## Which issue does this PR close?
   
   - Related to  https://github.com/apache/datafusion/pull/20180
   
   
   
   ## Rationale for this change
   
   I gave feedback to @devanshu0987  
https://github.com/apache/datafusion/pull/20180/changes#r2800720037 that it was 
not a good idea to check for function names in optimizer rules, but then I 
realized that the rationale for this is not written down anywhere.
   
   ## What changes are included in this PR?
   
   Document why checking for function names in optimizer rules is not good and 
offer alternatives
   
   ## Are these changes tested?
   
   By CI
   
   ## Are there any user-facing changes?
   
   Just docs, no functional changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to