fwojciec commented on PR #20391: URL: https://github.com/apache/datafusion/pull/20391#issuecomment-3911720335
> Welcome @fwojciec! Thank you for the detailed bug report and proposed fix. Both the analysis and the proposed fix seem reasonable to me. Appreciate the super-fast review @neilconway! > I wonder whether we should try to proactively prevent `Precision::Exact(ScalarValue::Null)` (same for Inexact) from being used for min/max/sum values in ColumnStatistics -- it doesn't seem to make much sense. Makes sense to me, would prevent this entire class of bugs. A separate PR (looks like that would be a slightly bigger change, though mostly mechanical). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
