andygrove commented on code in PR #3541:
URL: https://github.com/apache/datafusion-comet/pull/3541#discussion_r2818993832
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -223,12 +223,22 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
testTry = false)
}
- ignore("cast ByteType to TimestampType") {
- // input: -1, expected: 1969-12-31 15:59:59.0, actual: 1969-12-31
15:59:59.999999
- castTest(
- generateBytes(),
- DataTypes.TimestampType,
- hasIncompatibleType = usingParquetExecWithIncompatTypes)
+ test("cast ByteType to TimestampType") {
+ val compatibleTimezones = Seq(
+ "UTC",
+ "America/New_York",
+ "America/Los_Angeles",
+ "Europe/London",
+ "Asia/Tokyo",
+ "Australia/Sydney")
Review Comment:
could you extract the list of timezones into a variable that can be re-used
across tests to avoid duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
