Jefffrey commented on code in PR #20374:
URL: https://github.com/apache/datafusion/pull/20374#discussion_r2831044757
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -362,24 +373,34 @@ fn array_has_dispatch_for_scalar(
ArrayWrapper::LargeList(arr) => arr.nulls(),
};
- for (i, (start, end)) in haystack.offsets().tuple_windows().enumerate() {
- let length = end - start;
+ let offsets: Vec<usize> = haystack.offsets().collect();
+ let mut matches = eq_bits.set_indices().peekable();
Review Comment:
> Most of the time, the bitmap should be sparse, so I'd guess that
`set_slices()` won't be faster.
That sounds reasonable; we can keep this current approach 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
