neilconway commented on code in PR #20385: URL: https://github.com/apache/datafusion/pull/20385#discussion_r2833008241
########## datafusion/functions-nested/src/array_has.rs: ########## @@ -38,6 +38,7 @@ use crate::make_array::make_array_udf; use crate::utils::make_scalar_function; use std::any::Any; +use std::collections::HashSet; Review Comment: I'm happy to benchmark, although std HashSet uses hashbrown internally these days; have we found that using hashbrown directly leads to be better performance in other circumstances? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
