LiaCastaneda commented on code in PR #20416:
URL: https://github.com/apache/datafusion/pull/20416#discussion_r2839651075
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -497,15 +646,23 @@ mod test {
&filter_schema_1,
)
.unwrap();
- let snap = dynamic_filter_1.snapshot().unwrap().unwrap();
- insta::assert_snapshot!(format!("{snap:?}"), @r#"BinaryExpr { left:
Column { name: "a", index: 0 }, op: Eq, right: Literal { value: Int32(42),
field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow: false }"#);
+ let df1 = dynamic_filter_1
+ .as_any()
+ .downcast_ref::<DynamicFilterPhysicalExpr>()
+ .unwrap();
+ let current1 = df1.current().unwrap();
Review Comment:
Can we move back on asserting on the snapshot()? since it would have the
same outuput
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -497,15 +646,23 @@ mod test {
&filter_schema_1,
)
.unwrap();
- let snap = dynamic_filter_1.snapshot().unwrap().unwrap();
- insta::assert_snapshot!(format!("{snap:?}"), @r#"BinaryExpr { left:
Column { name: "a", index: 0 }, op: Eq, right: Literal { value: Int32(42),
field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow: false }"#);
+ let df1 = dynamic_filter_1
+ .as_any()
+ .downcast_ref::<DynamicFilterPhysicalExpr>()
+ .unwrap();
+ let current1 = df1.current().unwrap();
+ insta::assert_snapshot!(format!("{current1:?}"), @r#"BinaryExpr {
left: Column { name: "a", index: 0 }, op: Eq, right: Literal { value:
Int32(42), field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow:
false }"#);
Review Comment:
Can we move back to asserting on `dynamic_filter.snapshot()` since I think
they return the same output
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -497,15 +646,23 @@ mod test {
&filter_schema_1,
)
.unwrap();
- let snap = dynamic_filter_1.snapshot().unwrap().unwrap();
- insta::assert_snapshot!(format!("{snap:?}"), @r#"BinaryExpr { left:
Column { name: "a", index: 0 }, op: Eq, right: Literal { value: Int32(42),
field: Field { name: "lit", data_type: Int32 } }, fail_on_overflow: false }"#);
+ let df1 = dynamic_filter_1
+ .as_any()
+ .downcast_ref::<DynamicFilterPhysicalExpr>()
+ .unwrap();
+ let current1 = df1.current().unwrap();
Review Comment:
Can we move back on asserting on the snapshot()? since it would have the
same outuput
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
