rafafrdz commented on PR #3563:
URL:
https://github.com/apache/datafusion-comet/pull/3563#issuecomment-3949579852
Thanks for the suggestion @andygrove
What I did:
- Spark 4.0 RuntimeReplaceable / Invoke path: ParseUrl is now handled when
Spark rewrites it to `Invoke(ParseUrlEvaluator.evaluate, ...)`, so Comet serde
no longer misses it and we avoid "the invoke is not supported" fallback (please
check it out if it's correct or not)
- ANSI vs legacy behavior: serde now respects `failOnError`:
- failOnError = true (ANSI) -> parse_url (error on malformed URLs)
- failOnError = false (legacy) -> try_parse_url (returns NULL on malformed
URLs)
I also registered `try_parse_url` on the native side and added a test for
invalid URL handling in legacy mode (Spark 4.0 path).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
