kosiew commented on code in PR #20202:
URL: https://github.com/apache/datafusion/pull/20202#discussion_r2845831147
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -1003,6 +1005,41 @@ message PhysicalTryCastNode {
message PhysicalCastNode {
PhysicalExprNode expr = 1;
datafusion_common.ArrowType arrow_type = 2;
+ PhysicalCastOptions cast_options = 3;
+}
+
+message PhysicalCastColumnNode {
Review Comment:
I agree that adding protobuf for CastColumnExpr is not consistent with the
goal of merging into CastExpr later.
I would like to close this in favour of #20269 which has a more focused
scope and does not include protobuf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
