sdf-jkl commented on PR #18648: URL: https://github.com/apache/datafusion/pull/18648#issuecomment-3994244897
I'm convinced. We could split the PR into two smaller ones to make review easier: 1) Apply changes to the `preimage` api and the functions that already implement it. 2) Implement `preimage` for `date_trunc` Let me know if you think that's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
