timsaucer commented on PR #20705: URL: https://github.com/apache/datafusion/pull/20705#issuecomment-4004931830
@alamb Sorry for the extra changes, but as I was getting this ready for main/df53 I realized it was not as simple as setting `current_format` as an extra parameter. That changes how the visitor pattern works. This new approach adds to the unit test and verifies that all options are set, not only for those in the `current_format`. There is a bonus in that this will not be an API breaking change when we cherry pick it over to df53. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
