Dandandan commented on PR #20682:
URL: https://github.com/apache/datafusion/pull/20682#issuecomment-4010971345

   > Thanks @blaginin however I'm not sure about `mimalloc` for tests tbh, we 
do `mimalloc` for benchmarks, but tests asserts correctness and mem usage for 
default user environment which is glibc malloc or musl malloc if we speaking 
for Linux and providing results from another mem allocator as a source of 
truth, WDYT?
   
   I am not sure tests should depend on the allocator? If they would it might 
be possible to change the allocator just for those tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to