jonathanc-n commented on PR #20768: URL: https://github.com/apache/datafusion/pull/20768#issuecomment-4017476036
@Dandandan cleaned up the implementation. The performance hit came from using `ScalarValue::add` which did three unnecessary heap allocations. Now it performs an operation on the internal primitive types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
