andygrove commented on code in PR #3649: URL: https://github.com/apache/datafusion-comet/pull/3649#discussion_r2906413832
########## native/Cargo.toml: ########## @@ -71,4 +71,5 @@ strip = "debuginfo" inherits = "release" lto = false # Skip LTO for faster linking codegen-units = 16 # Parallel codegen (faster compile, slightly larger binary) +debug-assertions = true Review Comment: we wouldn't want to enable the assertions for releases because it would defeat the point of having the unsafe code that skips bounds checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
