friendlymatthew commented on PR #20822: URL: https://github.com/apache/datafusion/pull/20822#issuecomment-4025415489
> This looks great to me! > > How do we generate the right ProjectionMask / translate into the right leaf column index in Parquet? I don't see that added anywhere but maybe the existing code already did that correctly? We do not. I added a note in the PR message: > Note: this does not address the projection side and should not be blocked by it. SELECT s['foo'] still reads the entire struct rather than just the needed leaf column. That requires separate changes to how the opener builds its projection mask. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
