adriangb commented on code in PR #20749:
URL: https://github.com/apache/datafusion/pull/20749#discussion_r2898345002
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -3490,7 +3490,9 @@ pub struct Aggregate {
pub input: Arc<LogicalPlan>,
/// Grouping expressions
pub group_expr: Vec<Expr>,
- /// Aggregate expressions
+ /// Aggregate expressions.
+ ///
+ /// Note these *must* be either [`Expr::AggregateFunction`] or
[`Expr::Alias`]
Review Comment:
Should we make an `AggExpr { Function(...), Alias(...) }` enum then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
