parthchandra commented on code in PR #675: URL: https://github.com/apache/datafusion-comet/pull/675#discussion_r1680213976
########## kube/Dockerfile: ########## @@ -0,0 +1,45 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +FROM apache/spark:3.4.2 AS builder Review Comment: We could use `ARG` to parameterize this - ``` ARG BASE_IMAGE=apache/spark-3.4.3 FROM ${BASE_IMAGE} ``` Then the user can specify a different version of the Spark image - ``` docker build -f kube/Dockerfile --platform linux/amd64 \ --build-arg BASE_IMAGE=MY_BASE_IMAGE \ ... ``` I don't think we need to parameterize this as part of this PR. But potentially we could parameterize a bunch of the ENV variables similarly. See also: https://docs.docker.com/build/guide/build-args/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
