Michael-J-Ward commented on code in PR #750: URL: https://github.com/apache/datafusion-python/pull/750#discussion_r1680309889
########## python/datafusion/__init__.py: ########## @@ -15,206 +15,74 @@ # specific language governing permissions and limitations # under the License. -from abc import ABCMeta, abstractmethod -from typing import List +"""DataFusion python package. + +This is a Python library that binds to Apache Arrow in-memory query engine DataFusion. +See https://datafusion.apache.org/python/index.html for more information. Review Comment: ```suggestion See https://datafusion.apache.org/python for more information. ``` ########## benchmarks/db-benchmark/join-datafusion.py: ########## @@ -74,7 +74,8 @@ def ans_shape(batches): ctx = df.SessionContext() print(ctx) -# TODO we should be applying projections to these table reads to crete relations of different sizes +# TODO we should be applying projections to these table reads to crete relations Review Comment: ```suggestion # TODO we should be applying projections to these table reads to create relations ``` ########## examples/substrait.py: ########## @@ -18,16 +18,15 @@ from datafusion import SessionContext from datafusion import substrait as ss +# TODO add user changing interface note to PR that datafusion.substrait.substrait is simplified to datafusion.substrait Review Comment: Still `TODO`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
