alamb commented on PR #19316: URL: https://github.com/apache/datafusion/pull/19316#issuecomment-4031225393
> > > What about using `log::info!` or something (aka the existing logging hooks 🤔 ) > > I added `log::info` (as well as `log::error`, `log::warn`, ...) instead of `stdout`/`stderr`. > > I was also thinking of adding the query to the output, similar to Postgre's `auto_explain`. It would have to come from the unparsed logical plan since the original query is not available. However, maybe some users would not need the query, or maybe some would need other info that is not outputted. So maybe it might actually be better to leave this `auto_explain` feature for users to implement downstream as they wish. I think if you wanted to make it easier to implement downstream maybe we would add some sort of API / callback thing (trait object?) that could get the info for auto_explains. Then the default implementation could log with `info` and downstream users could override it if they wanted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
