andygrove commented on code in PR #3454:
URL: https://github.com/apache/datafusion-comet/pull/3454#discussion_r2914629031
##########
dev/diffs/4.0.1.diff:
##########
@@ -3562,7 +3666,7 @@ index f0f3f94b811..d64e4e54e22 100644
+ */
+ protected def enableCometAnsiMode: Boolean = {
+ val v = System.getenv("ENABLE_COMET_ANSI_MODE")
-+ v != null && v.toBoolean
++ if (v != null) v.toBoolean else true
+ }
Review Comment:
Actually, nm, it looks like this is for enabling Spark ANSI mode, not Comet
ANSI mode, so maybe the method name and env var name are just confusing. I will
take another look at this tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
