Dandandan commented on code in PR #20875:
URL: https://github.com/apache/datafusion/pull/20875#discussion_r2922444316
##########
datafusion/common/src/config.rs:
##########
@@ -684,6 +684,14 @@ config_namespace! {
///
/// Disabled by default, set to a number greater than 0 for enabling
it.
pub hash_join_buffering_capacity: usize, default = 0
+
+ /// When set to true, after executing a plan via `collect()` or
+ /// `collect_partitioned()`, DataFusion verifies that operators
+ /// declaring `CardinalityEffect::Equal` produced exactly the same
+ /// number of output rows as their input. This is a post-execution
+ /// sanity check useful for debugging correctness issues.
+ /// Disabled by default as it adds a small amount of overhead.
+ pub verify_cardinality_effect: bool, default = false
Review Comment:
Can you check whether enabling by default will pass all the (unit/slt/...)
tests?
I wonder if all the `ExecutionPlan` update the metrics correctly after
executing (would be a great way anyway of verifying this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
