andygrove commented on code in PR #3546:
URL: https://github.com/apache/datafusion-comet/pull/3546#discussion_r2940589124
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -139,9 +139,24 @@ case class CometScanRule(session: SparkSession)
private def transformV1Scan(plan: SparkPlan, scanExec: FileSourceScanExec):
SparkPlan = {
- if (COMET_DPP_FALLBACK_ENABLED.get() &&
- scanExec.partitionFilters.exists(isDynamicPruningFilter)) {
- return withInfo(scanExec, "Dynamic Partition Pruning is not supported")
+ val hasDPP = scanExec.partitionFilters.exists(isDynamicPruningFilter)
+ val aqeEnabled = session.sessionState.conf.adaptiveExecutionEnabled
+ val scanImpl = COMET_NATIVE_SCAN_IMPL.get()
+
+ // native_datafusion + DPP requires AQE. Without AQE, DPP subqueries
aren't prepared
+ // before the scan tries to use their results, causing "has not finished"
errors.
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
