andygrove commented on code in PR #3546:
URL: https://github.com/apache/datafusion-comet/pull/3546#discussion_r2940622211


##########
spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q1.native_datafusion/extended.txt:
##########
@@ -14,7 +14,7 @@ TakeOrderedAndProject
       :     :     :                 +- BroadcastHashJoin
       :     :     :                    :- Filter
       :     :     :                    :  +- ColumnarToRow
-      :     :     :                    :     +-  Scan parquet 
spark_catalog.default.store_returns [COMET: Native DataFusion scan does not 
support subqueries/dynamic pruning]

Review Comment:
   I'd suggest not changing the fallback message for this PR and have a follow 
on PR to improve the message, so that this PR is smaller and just focuses on 
the functionality.
   
   Another option is to add a new config to feature gate the DPP support and 
disable it for now in the stability suite.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to