buraksenn opened a new pull request, #20963: URL: https://github.com/apache/datafusion/pull/20963
## Which issue does this PR close? - Closes #608. ## Rationale for this change #608 has details but as @alamb describes in https://github.com/apache/datafusion/issues/608#issuecomment-4034162591 ``` SELECT c2 FROM test ORDER BY max(c3) OVER (ORDER BY c9); ``` fails with: ``` This feature is not implemented: Physical plan does not support logical expression WindowFunction(WindowFunction { fun: AggregateUDF(AggregateUDF { inner: Max { signature: Signature { type_signature: UserDefined, volatility: Immutable, parameter_names: None } } }), params: WindowFunctionParams { args: [Column(Column { relation: Some(Bare { table: "test" }), name: "c3" })], partition_by: [], order_by: [Sort { expr: Column(Column { relation: Some(Bare { table: "test" }), name: "c9" }), asc: true, nulls_first: false }], window_frame: WindowFrame { units: Range, start_bound: Preceding(Int32(NULL)), end_bound: CurrentRow, is_causal: false }, filter: None, null_treatment: None, distinct: false } }) ``` ## What changes are included in this PR? - relevant change - slt and unit tests ## Are these changes tested? Yes added both unit tests for plan and slt tests for checking output ## Are there any user-facing changes? Additive user changes that users can now use window in order by expressions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
