comphead commented on code in PR #20946:
URL: https://github.com/apache/datafusion/pull/20946#discussion_r2942645163
##########
datafusion/common/src/error.rs:
##########
@@ -903,76 +903,123 @@ macro_rules! assert_ne_or_internal_err {
/// plan_err!("Error {val:?}")
///
/// `NAME_ERR` - macro name for wrapping Err(DataFusionError::*)
+/// `PREFIXED_NAME_ERR` - underscore-prefixed alias for NAME_ERR (e.g.,
_plan_err)
/// `NAME_DF_ERR` - macro name for wrapping DataFusionError::*. Needed to
keep backtrace opportunity
/// in construction where DataFusionError::* used directly, like `map_err`,
`ok_or_else`, etc
+/// `PREFIXED_NAME_DF_ERR` - underscore-prefixed alias for NAME_DF_ERR (e.g.,
_plan_datafusion_err)
Review Comment:
```suggestion
/// `PREFIXED_NAME_DF_ERR` - underscore-prefixed alias for NAME_DF_ERR
(e.g., _plan_datafusion_err). Needed to avoid compiler error when using macro
in the same crate: `macros from the current crate cannot be referred to by
absolute paths`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
