martin-g commented on code in PR #20804:
URL: https://github.com/apache/datafusion/pull/20804#discussion_r2956303359
##########
datafusion/spark/src/function/datetime/make_interval.rs:
##########
@@ -278,6 +278,7 @@ mod tests {
};
use super::*;
+ use datafusion_expr::ScalarFunctionArgs;
Review Comment:
line 28
```suggestion
```
##########
datafusion/functions/src/string/lower.rs:
##########
@@ -99,6 +99,7 @@ mod tests {
use arrow::array::{Array, ArrayRef, StringArray, StringViewArray};
use arrow::datatypes::Field;
use datafusion_common::config::ConfigOptions;
+ use datafusion_expr::ScalarFunctionArgs;
Review Comment:
Not needed here. It is already imported at line 25
```suggestion
```
##########
datafusion/functions/src/math/log.rs:
##########
@@ -418,6 +418,7 @@ mod tests {
use arrow::datatypes::{DECIMAL256_MAX_PRECISION, Field};
use datafusion_common::cast::{as_float32_array, as_float64_array};
use datafusion_common::config::ConfigOptions;
+ use datafusion_expr::ScalarFunctionArgs;
Review Comment:
Already imported at line 40
```suggestion
```
##########
datafusion/functions/src/string/upper.rs:
##########
@@ -98,6 +98,7 @@ mod tests {
use arrow::array::{Array, ArrayRef, StringArray, StringViewArray};
use arrow::datatypes::Field;
use datafusion_common::config::ConfigOptions;
+ use datafusion_expr::ScalarFunctionArgs;
Review Comment:
Already imported at line 23
```suggestion
```
##########
datafusion/physical-expr/src/scalar_function.rs:
##########
@@ -375,7 +375,7 @@ mod tests {
use super::*;
use crate::expressions::Column;
use arrow::datatypes::{DataType, Field, Schema};
- use datafusion_expr::{ScalarUDF, ScalarUDFImpl, Signature};
+ use datafusion_expr::{ScalarFunctionArgs, ScalarUDF, ScalarUDFImpl,
Signature};
Review Comment:
line 48
```suggestion
use datafusion_expr::{ScalarUDF, ScalarUDFImpl, Signature};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
