jonahgao commented on code in PR #21049:
URL: https://github.com/apache/datafusion/pull/21049#discussion_r2957804587
##########
datafusion/sqllogictest/src/test_context.rs:
##########
@@ -98,9 +98,9 @@ impl TestContext {
let file_name = relative_path.file_name().unwrap().to_str().unwrap();
match file_name {
- "cte_quoted_reference.slt" => {
Review Comment:
`cte_quoted_reference.slt` has been consolidated into `cte.slt`, and no
longer exists.
##########
datafusion/sqllogictest/src/test_context.rs:
##########
@@ -265,14 +245,10 @@ fn register_strict_orders_catalog(ctx: &SessionContext) {
orders: Arc::new(orders),
});
- // Override the default "datafusion" catalog for this test file so that any
- // unexpected lookup is caught immediately.
- ctx.register_catalog(
Review Comment:
Register a new schema instead of overriding the default datafusion catalog
to avoid impacting other CTE tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
