0lai0 opened a new pull request, #3732:
URL: https://github.com/apache/datafusion-comet/pull/3732
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3138
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Comet previously did not support the Spark `PreciseTimestampConversion`
expression.
This expression is not called directly by users, but is generated internally
by Spark's Analyzer when it rewrites window_time(window_column) into a
combination of GetStructField, Subtract, and PreciseTimestampConversion. Since
Comet already supports GetStructField and Subtract but not
PreciseTimestampConversion, queries using window_time would fall back to JVM
execution.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This change adds a Serde handler for PreciseTimestampConversion that reuses
the existing Cast protobuf and Rust implementation. Since TimestampType
(microseconds) and LongType share the same 64-bit memory layout in Arrow, a
simple cast suffices without any new native code paths.
- `datetime.scala` : Added CometPreciseTimestampConversion handler
- `QueryPlanSerde.scala` : Registered the handler in temporalExpressions map
- `CometExpressionSuite.scala` : Added window_time test with tumbling and
sliding window scenarios
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added a Scala unit test for `window_time expression` support in
`CometExpressionSuite`
`./mvnw test -Dsuites="org.apache.comet.CometExpressionSuite"
-Dscala.useZincServer=false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
