parthchandra commented on code in PR #3731:
URL: https://github.com/apache/datafusion-comet/pull/3731#discussion_r2963417363
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -343,6 +343,17 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(true)
+ val COMET_SHUFFLE_DIRECT_READ_ENABLED: ConfigEntry[Boolean] =
+ conf("spark.comet.shuffle.directRead.enabled")
+ .category(CATEGORY_EXEC)
Review Comment:
Should this be `CATEGORY_SHUFFLE` ?
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala:
##########
@@ -437,4 +437,19 @@ class CometNativeShuffleSuite extends CometTestBase with
AdaptiveSparkPlanHelper
}
}
}
+
+ test("shuffle direct read produces same results as FFI path") {
Review Comment:
Should we also test a case with multiple shuffles in the plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
