andygrove commented on PR #3731: URL: https://github.com/apache/datafusion-comet/pull/3731#issuecomment-4098485651
> > Shows 13% improvement in TPC-H @ 1TB. > > Nice work! I didn't expect removing FFI to bring such great benefits. Could you share where these benefits mainly come from? Is it due to fewer JNI calls, or was the overhead from ArrowImporter relatively high? Thanks! Yes, the overhead from export/import is high, including serializing the schema for every batch. In this case, doing export/import at all was just not needed, so the overhead was just unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
