andygrove commented on code in PR #3730:
URL: https://github.com/apache/datafusion-comet/pull/3730#discussion_r2965873787
##########
native/spark-expr/src/conversion_funcs/string.rs:
##########
@@ -1027,28 +1054,19 @@ fn parse_timestamp_to_micros<T: TimeZone>(
timestamp_info.second,
);
- // Check if datetime is not None
- let tz_datetime = match datetime.single() {
+ // Spark uses the offset before daylight savings change so we need to use
earliest()
+ // Return None for LocalResult::None which is the invalid time in a DST
spring forward gap).
Review Comment:
Do existing tests cover any DST spring forward gaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
