0lai0 commented on PR #3746:
URL:
https://github.com/apache/datafusion-comet/pull/3746#issuecomment-4105535276
Thanks @andygrove for the review! All three comments have been addressed and
also fixed the Spark 4.0 compilation failures.
The root cause was two removed APIs in Spark 4:
- Column(Expression) constructor → replaced with getColumnFromExpression()
shim
- Column.expr property → replaced with UnresolvedAttribute to construct
column references directly in test code
Both Spark 3.5 (tests pass) and Spark 4.0 (compilation verified) are working
in local.
`./mvnw test -pl spark \
-Dsuites="org.apache.comet.CometTemporalExpressionSuite" \
-Dtest="none" -DfailIfNoTests=false
`
`./mvnw test-compile -Pspark-4.0
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
