rluvaton commented on code in PR #18921:
URL: https://github.com/apache/datafusion/pull/18921#discussion_r2971361327
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -971,11 +971,27 @@ pub fn take_function_args<const N: usize, T>(
})
}
+/// Returns the inner values of a list, or an error otherwise
+/// For [`ListArray`] and [`LargeListArray`], if it's sliced, it returns a
+/// sliced array too. Therefore, too reconstruct a list using it,
+/// you must adjust the offsets using [`adjust_offsets_for_slice`]
Review Comment:
You are not returning the sliced values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
