vaibhawvipul commented on PR #3759: URL: https://github.com/apache/datafusion-comet/pull/3759#issuecomment-4115521988
> @vaibhawvipul thanks again for investigating this. Many Spark SQL tests are currently ignored when running with `native_datafusion` scan due to #3720 which this PR aims to fix. Can you update the Spark diffs to enable these tests so that we can see that they now pass in CI with the changes in this PR? Instructions for regenerating the diffs are at https://datafusion.apache.org/comet/contributor-guide/spark-sql-tests.html > > Without the tests enabled it is hard to know whether this PR is actually fixing the issue. addressed. Updated all three Spark diffs . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
