coderfender commented on code in PR #21030:
URL: https://github.com/apache/datafusion/pull/21030#discussion_r2984944700
##########
datafusion/ffi/src/util.rs:
##########
@@ -17,59 +17,63 @@
use std::sync::Arc;
-use abi_stable::std_types::{RResult, RString, RVec};
use arrow::datatypes::{DataType, Field};
use arrow::ffi::FFI_ArrowSchema;
use arrow_schema::FieldRef;
+use stabby::string::String as SString;
+use stabby::vec::Vec as SVec;
use crate::arrow_wrappers::WrappedSchema;
+// Re-export for convenience
+pub use crate::ffi_option::{FfiOption, FfiResult};
+
/// Convenience type for results passed through the FFI boundary. Since the
/// `DataFusionError` enum is complex and little value is gained from creating
/// a FFI safe variant of it, we convert errors to strings when passing results
/// back. These are converted back and forth using the `df_result`, `rresult`,
/// and `rresult_return` macros.
-pub type FFIResult<T> = RResult<T, RString>;
+pub type FFIResult<T> = FfiResult<T, SString>;
Review Comment:
Agreed ! Sure I will stick with the naming conventions currently followed
##########
datafusion/ffi/src/volatility.rs:
##########
@@ -15,18 +15,17 @@
// specific language governing permissions and limitations
// under the License.
-use abi_stable::StableAbi;
use datafusion_expr::Volatility;
-#[repr(C)]
-#[derive(Debug, StableAbi, Clone)]
-pub enum FFI_Volatility {
+#[repr(u8)]
+#[derive(Debug, Clone)]
+pub enum FfiVolatility {
Review Comment:
Sure !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
