coderfender commented on code in PR #21030:
URL: https://github.com/apache/datafusion/pull/21030#discussion_r2985719538
##########
datafusion-examples/examples/ffi/ffi_module_interface/src/lib.rs:
##########
@@ -15,36 +15,17 @@
// specific language governing permissions and limitations
// under the License.
-use abi_stable::{
- StableAbi, declare_root_module_statics,
- library::{LibraryError, RootModule},
- package_version_strings,
- sabi_types::VersionStrings,
-};
use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec;
use datafusion_ffi::table_provider::FFI_TableProvider;
-#[repr(C)]
-#[derive(StableAbi)]
-#[sabi(kind(Prefix(prefix_ref = TableProviderModuleRef)))]
/// This struct defines the module interfaces. It is to be shared by
/// both the module loading program and library that implements the
/// module. It is possible to move this definition into the loading
/// program and reference it in the modules, but this example shows
/// how a user may wish to separate these concerns.
+#[repr(C)]
Review Comment:
That said this might change in future version's of stabby and we could
update it to use stabby's macro impl instead of plain `repr(C)` (not that it
doesnt fulfil our needs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
