neilconway commented on code in PR #21119:
URL: https://github.com/apache/datafusion/pull/21119#discussion_r2988242624
##########
datafusion/functions/src/string/split_part.rs:
##########
@@ -123,71 +126,50 @@ impl ScalarUDFImpl for SplitPartFunc {
// Unpack the ArrayRefs from the arguments
let n_array = as_int64_array(&args[2])?;
- let result = match (args[0].data_type(), args[1].data_type()) {
- (DataType::Utf8View, DataType::Utf8View) => {
- split_part_impl::<&StringViewArray, &StringViewArray, i32>(
- &args[0].as_string_view(),
- &args[1].as_string_view(),
- n_array,
- )
- }
- (DataType::Utf8View, DataType::Utf8) => {
- split_part_impl::<&StringViewArray, &GenericStringArray<i32>,
i32>(
- &args[0].as_string_view(),
- &args[1].as_string::<i32>(),
- n_array,
- )
- }
- (DataType::Utf8View, DataType::LargeUtf8) => {
- split_part_impl::<&StringViewArray, &GenericStringArray<i64>,
i32>(
- &args[0].as_string_view(),
- &args[1].as_string::<i64>(),
- n_array,
- )
- }
- (DataType::Utf8, DataType::Utf8View) => {
- split_part_impl::<&GenericStringArray<i32>, &StringViewArray,
i32>(
- &args[0].as_string::<i32>(),
- &args[1].as_string_view(),
- n_array,
- )
- }
- (DataType::LargeUtf8, DataType::Utf8View) => {
- split_part_impl::<&GenericStringArray<i64>, &StringViewArray,
i64>(
- &args[0].as_string::<i64>(),
- &args[1].as_string_view(),
- n_array,
- )
- }
- (DataType::Utf8, DataType::Utf8) => {
- split_part_impl::<&GenericStringArray<i32>,
&GenericStringArray<i32>, i32>(
- &args[0].as_string::<i32>(),
- &args[1].as_string::<i32>(),
- n_array,
- )
- }
- (DataType::LargeUtf8, DataType::LargeUtf8) => {
- split_part_impl::<&GenericStringArray<i64>,
&GenericStringArray<i64>, i64>(
- &args[0].as_string::<i64>(),
- &args[1].as_string::<i64>(),
- n_array,
- )
- }
- (DataType::Utf8, DataType::LargeUtf8) => {
- split_part_impl::<&GenericStringArray<i32>,
&GenericStringArray<i64>, i32>(
- &args[0].as_string::<i32>(),
- &args[1].as_string::<i64>(),
- n_array,
- )
- }
- (DataType::LargeUtf8, DataType::Utf8) => {
- split_part_impl::<&GenericStringArray<i64>,
&GenericStringArray<i32>, i64>(
- &args[0].as_string::<i64>(),
- &args[1].as_string::<i32>(),
- n_array,
- )
- }
- _ => exec_err!("Unsupported combination of argument types for
split_part"),
+
+ // Dispatch on delimiter type for a given string array and builder.
+ macro_rules! split_part_for_delimiter_type {
+ ($str_arr:expr, $builder:expr) => {
+ match args[1].data_type() {
+ DataType::Utf8View => split_part_impl(
+ $str_arr,
+ &args[1].as_string_view(),
+ n_array,
+ $builder,
+ ),
+ DataType::Utf8 => split_part_impl(
+ $str_arr,
+ &args[1].as_string::<i32>(),
+ n_array,
+ $builder,
+ ),
+ DataType::LargeUtf8 => split_part_impl(
+ $str_arr,
+ &args[1].as_string::<i64>(),
+ n_array,
+ $builder,
+ ),
+ other => {
+ exec_err!("Unsupported delimiter type {other:?} for
split_part")
+ }
+ }
+ };
+ }
+
+ let result = match args[0].data_type() {
+ DataType::Utf8View => split_part_for_delimiter_type!(
+ &args[0].as_string_view(),
+ StringViewBuilder::with_capacity(inferred_length)
+ ),
+ DataType::Utf8 => split_part_for_delimiter_type!(
+ &args[0].as_string::<i32>(),
+ GenericStringBuilder::<i32>::new()
+ ),
Review Comment:
Good idea, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
