etiennepelissier commented on code in PR #21112: URL: https://github.com/apache/datafusion/pull/21112#discussion_r2988571789
########## datafusion/substrait/src/logical_plan/consumer/rel/read_rel.rs: ########## Review Comment: To close the loop: the final API has `resolve_table_ref` taking `hints: SubstraitHints` (a `#[non_exhaustive]` struct with `row_count: Option<f64>` and `record_size: Option<f64>`), rather than the intermediate `row_count_hint: Option<f64>` mentioned in my earlier reply. `StatisticsOverrideTableProvider` is private to `DefaultSubstraitConsumer` — custom implementors can ignore the hints or embed them directly into their own `TableProvider`. Happy to walk through anything before you re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
