zhuqi-lucas commented on PR #21126: URL: https://github.com/apache/datafusion/pull/21126#issuecomment-4152253007
Hi @aadae6bda — this PR (merged on 3/29) fixed duplicate column name support, which is great! However it caused the sqlite test suite to fail on main: queries that were previously expected to fail with `Projections require unique expression names` now succeed. There are ~279 sqlite SLT files in `datafusion-testing` that need their `query error` entries updated to actual results. See CI failure: https://github.com/apache/datafusion/actions/runs/23727414778 This needs a PR to the [datafusion-testing](https://github.com/apache/datafusion-testing) repo (similar to https://github.com/apache/datafusion-testing/pull/14). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
