UBarney commented on code in PR #21090:
URL: https://github.com/apache/datafusion/pull/21090#discussion_r3009849948


##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -8787,3 +8787,73 @@ set datafusion.execution.target_partitions = 4;
 
 statement ok
 DROP TABLE stream_test;
+
+
+#################
+# first_value on strings/binary with groups and ordering

Review Comment:
   Good point. I've added a test case for `last_value` in `aggregate.slt` as 
well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to