shehab-ali commented on code in PR #21262:
URL: https://github.com/apache/datafusion/pull/21262#discussion_r3012109374
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -978,6 +978,20 @@ impl SessionState {
/// A builder to be used for building [`SessionState`]'s. Defaults will
/// be used for all values unless explicitly provided.
///
+/// Deduplicates function-registry map entries by keeping only entries whose
key
+/// matches the canonical name. The session stores one hash map entry per alias
+/// plus the canonical name; filtering to canonical-name entries yields exactly
+/// one [`Arc`] per logical function.
+fn dedup_function_registry_by_canonical_name<T>(
+ map: &HashMap<String, Arc<T>>,
+ canonical_name: impl Fn(&T) -> &str,
Review Comment:
those function have different types though: `WindowUDF, ScalarUDF,
AggregateUDF`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
