adriangb commented on code in PR #21182:
URL: https://github.com/apache/datafusion/pull/21182#discussion_r3012544293
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -896,28 +896,90 @@ impl DataSource for FileScanConfig {
}
}
+ /// Push sort requirements into file-based data sources.
+ ///
+ /// # Sort Pushdown Architecture
+ ///
+ /// ```text
+ /// Query: SELECT ... ORDER BY col ASC [LIMIT N]
+ ///
+ /// PushdownSort optimizer
+ /// │
+ /// ▼
+ /// FileScanConfig::try_pushdown_sort()
+ /// │
+ /// ├─► FileSource::try_pushdown_sort()
+ /// │ │
+ /// │ ├─ natural ordering matches? ──► Exact
+ /// │ │ (e.g. Parquet WITH ORDER) │
+ /// │ │ ▼
Review Comment:
```suggestion
/// │ │ ▼
```
##########
datafusion/sqllogictest/test_files/sort_pushdown.slt:
##########
@@ -1193,7 +1193,7 @@ logical_plan
02)--TableScan: reversed_with_order_parquet projection=[id, value]
physical_plan
01)SortExec: expr=[id@0 ASC NULLS LAST], preserve_partitioning=[false]
-02)--DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/sort_pushdown/reversed/a_high.parquet,
WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/sort_pushdown/reversed/b_mid.parquet,
WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/sort_pushdown/reversed/c_low.parquet]]},
projection=[id, value], file_type=parquet
+02)--DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/sort_pushdown/reversed/c_low.parquet,
WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/sort_pushdown/reversed/b_mid.parquet,
WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/sort_pushdown/reversed/a_high.parquet]]},
projection=[id, value], file_type=parquet
Review Comment:
Very nice!
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -811,11 +819,6 @@ impl FileSource for ParquetSource {
Ok(SortOrderPushdownResult::Inexact {
inner: Arc::new(new_source) as Arc<dyn FileSource>,
})
-
- // TODO Phase 2: Add support for other optimizations:
Review Comment:
If you're able to open a followup issue and link it to the PR and code that
would be great!
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -896,28 +896,90 @@ impl DataSource for FileScanConfig {
}
}
+ /// Push sort requirements into file-based data sources.
+ ///
+ /// # Sort Pushdown Architecture
+ ///
+ /// ```text
+ /// Query: SELECT ... ORDER BY col ASC [LIMIT N]
+ ///
+ /// PushdownSort optimizer
+ /// │
+ /// ▼
+ /// FileScanConfig::try_pushdown_sort()
+ /// │
+ /// ├─► FileSource::try_pushdown_sort()
+ /// │ │
+ /// │ ├─ natural ordering matches? ──► Exact
+ /// │ │ (e.g. Parquet WITH ORDER) │
+ /// │ │ ▼
+ /// │ │ rebuild_with_source(exact=true)
+ /// │ │ ├─ sort files by stats within
groups
+ /// │ │ ├─ verify non-overlapping
+ /// │ │ └─► keep output_ordering →
SortExec removed
+ /// │ │
+ /// │ ├─ reversed ordering matches? ──► Inexact
+ /// │ │ (reverse_row_groups=true) │
+ /// │ │ ▼
Review Comment:
```suggestion
/// │ │ ▼
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
