comphead commented on code in PR #3842:
URL: https://github.com/apache/datafusion-comet/pull/3842#discussion_r3016598050
##########
spark/src/test/scala/org/apache/spark/sql/comet/CometTaskMetricsSuite.scala:
##########
@@ -91,4 +94,66 @@ class CometTaskMetricsSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
}
+
+ test("native_datafusion scan reports task-level input metrics matching
Spark") {
+ withParquetTable((0 until 10000).map(i => (i, (i + 1).toLong)), "tbl") {
+ // Collect baseline input metrics from vanilla Spark (Comet disabled)
+ val (sparkBytes, sparkRecords) =
collectInputMetrics(CometConf.COMET_ENABLED.key -> "false")
+
+ // Collect input metrics from Comet native_datafusion scan
+ val (cometBytes, cometRecords) = collectInputMetrics(
+ CometConf.COMET_NATIVE_SCAN_IMPL.key ->
CometConf.SCAN_NATIVE_DATAFUSION)
Review Comment:
`CometConf.COMET_ENABLED.key -> "true",` is enabled on test level by
default, but I think we might ensure Comet operators was applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
